Fixes #7527 - don't require less in production unless from rake

[iNecas]

No description provided.

[lzap]

Cool, I see tests failing.

[iNecas]

@jlsherrill I've updated the condition on determining if to add the paths to the config.less based on the presence of the Less::Rails so that there is one place to decide if the less-rails should be loaded or not

[iNecas]

also, the tests should be green after jenkins finishes

[jlsherrill]

tested the build on a nightly and worked great. ACK from me, any thoughts @ehelms ?

[ehelms]

It feels ugly, and prone to potentially break on us again. I'm OK with this fix, but from those that have investigated it heavily, is there anything we can do to make a change in https://github.com/cowboyd/less.rb or work with them to avoid having to do this in the future?

[iNecas]

Personally, I would like to avoid this kind of deps in production, even when the particular execmem error wasn't there: the assets (any any other type of) compilation should be always extracted outside of production server runtime

[ehelms]

@iNecas I agree, I think by default Rails compiles assets in the production environment due to the settings around compilation :/ I wonder if we could introduce another environment? (ACK for this PR)

[iNecas]

----- Original Message -----

@iNecas I agree, I think by default Rails compiles assets in the production
environment due to the settings around compilation :/ I wonder if we could
introduce another environment? (ACK for this PR)

By "production runtime" environment, I mean the httpd/foreman-proxy
service, that are long-running processes. The production environment
in rake is not that big problem: also the selinux is not being applied
in that case.

---

Reply to this email directly or view it on GitHub:
#4673 (comment)