Fixes #7493 - Store description entered during publish #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
changed the title
daviddavis
changed the title
daviddavis
changed the title
daviddavis
changed the title
|
@daviddavis what is the reasoning behind having description, notes and publish_description all to describe the same field? |
|
So the notes field holds the description for a publish or a promote. I think we could rename it to description for consistency. Thus, you would have description (the db field), publish_description, and (eventually) promote_description. |
|
@ehelms updated to use a consistent column (description). |
| $scope.working = true; | ||
| ContentView.publish(contentView, success, failure); | ||
| ContentView.publish(data, success, failure); |
There was a problem hiding this comment.
Why aren't you able to just send the contentView object as the data here?
There was a problem hiding this comment.
Because contentView has a description. What we're passing here to the API is a description for the new content view version.
|
ACK |
daviddavis
pushed a commit
that referenced
this pull request
Sep 29, 2014
Fixes #7493 - Store description entered during publish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.