content-deletion - changes to UI based on mockups #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial commit to add a banner to the changeset sliding tree to allow a user to view either promotion or deletion changesets...
…n/promotion) This is an initial commit to provide changes to support the appearance of 2 separate sliding trees for promotion and deletion changesets. There is more work to be done to get this to work when applying the changesets...etc.
If the user accesses the changesets page with a changeset hash (e.g. "#changeset=changeset_10") and that changeset is a deletion changeset, load the page with the deletion changeset sliding tree selected; otherwise, use the default behavior which is to load the page with the promotion changeset sliding tree selected.
…sting Previously we had a single list consisting of all changesets. In that listing, we included some text to indicate the type for each changeset (i.e. deletion/promotion). Since we are now creating 2 separate lists, that type is no longer necessary; therefore, removing it.
…Remove' This commit contains changes so that when an item (e.g. product, pkg, errata...) is added to the changeset, the content tree includes "Added (Undo)" (where undo is a link) vs "Remove". Although this affects the content tree (left side), it does not affect the changeset tree (right side), which will continue to use 'Remove'. This commit also contains a small fix to allow repos to be removed from a changeset after they have been added. Previously there was a bug where the repo once added was not correctly detected by the changeset 'has_item' method.
…Remove' This is a follow-up to the previous commit to address the changes needed to the system templates view.
This commit adds the title attribute to the items in the changeset action bar (e.g. Remove, Edit Details, Review, Promote/Edit). For simplicity/efficiency, chose to use html title attribute for these vs creating a tipsy element.
Update to have a custom confirm on changeset deletion, so user is aware of the type of changeset they are deleting.
Added a tipsy to the 'Added' text in the content tree so that when user hovers, they see info like "Added to changeset XYZ".
Added title attribute to changeset actions (e.g. Remove, Edit..etc); however, noticed that tipsy is used in this page quite a bit but title is not. As a result, updated them to use tipsy for consistency. Also, added a 'tipsify' class so that we can have a single instantiation of tipsy for the tipsies added for the actions, the ones used for the "Added (Undo)" and others in the future.
| 'you have created a change set, click the "Promote" button to commit it to the next environment.')) | | ||
| = help_tip(_('Changesets allow you to either promote content to or delete content from ' + | | ||
| 'an environment.<BR/><BR/> ' + | | ||
| 'For a promotion, you may promote content from one environment to the ' + | |
There was a problem hiding this comment.
Is adding a <BR/><BR/> a good idea in 18n text ?
There was a problem hiding this comment.
It is probably not the best; however, we've had to do it in certain places for helptips to have them render better.
|
Sounds good otherwise . |
|
ACK from me, merge away |
parthaa
added a commit
that referenced
this pull request
Aug 16, 2012
content-deletion - changes to UI based on mockups
| $.each(current_changeset.getProducts(), function(index, product) { | ||
| $.each(buttons, function(button_index, button){ | ||
| if( $(button).attr('id') === ('add_remove_product_' + product.id) ){ | ||
| if( product.all === true){ | ||
| $(button).html(i18n.remove).removeClass('add_product').addClass("remove_product").removeClass("disabled"); | ||
| $(button).html(i18n.undo).removeClass('add_product').addClass("remove_product").removeClass("disabled"); | ||
| $(button).prev('.added').removeClass('hidden').attr('original-title', i18n.added_to_changeset(current_changeset.getName())); |
There was a problem hiding this comment.
Are you sure you want to change the HTML (.html()) or the TEXT (.text()) or perhaps attr('value')?
There was a problem hiding this comment.
On the line that is commented (which uses attr()), we do want to modify the 'original-title' attribute. This is the default attribute used by tipsy.
If the comment is to apply to the previous line (which uses html()) ,that is actually the existing code; however, we wanted to change the text that was rendered. In this case, I believe we can actually use html or text to achieve the same result; however, text may be more appropriate. Will check and include in a separate pull request if needed (since this one got merged just before the comment)
Thanks for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the Changesets UI to account for the wireframes at:
https://fedorahosted.org/katello/wiki/ContentDeletionDesign
Highlevel summary of changes include: