Fixes #7730,BZ1127090 - Activation key max host count can be set from finite n... #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
bz1127090-activation_key
branch
from
68539e2
to
610bf4e
Compare
|
@adamruzicka is there a Redmine issue for this bug? |
|
@ehelms couldn't find any relevant on Redmind, created new one for it http://projects.theforeman.org/issues/7730 |
|
@adamruzicka thanks! could you also update your commit message to |
|
ACK |
adamruzicka
changed the title
|
@ehelms sorry, forgot to rename it after creating the redmine |
|
@adamruzicka one last change, for our system to work properly we need the commit message (and not the pull request message) to reflect what is being fixed. If you wouldn't mind amending the commit message with the same thing the new PR message says that would be great. |
…et from finite number to infinite
adamruzicka
force-pushed
the
bz1127090-activation_key
branch
from
610bf4e
to
d40cef4
Compare
|
@ehelms sure thing, done |
ehelms
added
Ready for merge
and removed
Needs testing
Not yet reviewed
Waiting on contributor
labels
|
@adamruzicka thanks! |
ehelms
added a commit
that referenced
this pull request
Sep 30, 2014
Fixes #7730,BZ1127090 - Activation key max host count can be set from finite n...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...umber to infinite