fixes #7834 - properly process incoming and updated hypervisors #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| System.create_hypervisor(environment.id, content_view.id, hypervisor_attrs) | ||
| created = [] | ||
| consumers_attrs[:created].map do |hypervisor| | ||
| created << System.create_hypervisor(environment.id, content_view.id, hypervisor) | ||
| end if consumers_attrs[:created] |
There was a problem hiding this comment.
Why use map if you're not setting it to anything? Here you go:
created = (consumers_attrs[:created] || []).map do |hypervisor|
System.create_hypervisor(environment.id, content_view.id, hypervisor)
end
thomasmckay
force-pushed
the
7834-hypervisors
branch
from
eb4ab3b
to
e27dead
Compare
|
@daviddavis updated, thanks! Hope you don't mind but I left the var initialization in place. |
|
That works. APJ |
| System.create_hypervisor(environment.id, content_view.id, hypervisor_attrs) | ||
| created = [] | ||
| consumers_attrs[:created].each do |hypervisor| | ||
| created << System.create_hypervisor(environment.id, content_view.id, hypervisor) | ||
| end if consumers_attrs[:created] |
There was a problem hiding this comment.
My preference is for trailing if's to only be on single-line statements. This is more readable to me:
if consumers_attrs[:created]
consumers_attrs[:created].each do |hypervisor|
created << System.create_hypervisor(environment.id, content_view.id, hypervisor)
end
end
There was a problem hiding this comment.
+1. To be fair though, this was not introduced by @thomasmckay.
|
APJ, I won't withold my ack because of the above, just a nitpick, but if you feel like changing it :-) |
thomasmckay
force-pushed
the
7834-hypervisors
branch
from
e27dead
to
81afb11
Compare
thomasmckay
force-pushed
the
7834-hypervisors
branch
from
81afb11
to
6057a37
Compare
changed unneeded map to each changed 'if' style on code rebased rubocop fix
thomasmckay
force-pushed
the
7834-hypervisors
branch
from
6057a37
to
f753644
Compare
thomasmckay
added a commit
that referenced
this pull request
Oct 17, 2014
fixes #7834 - properly process incoming and updated hypervisors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.