Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #6463 - hammer was unable to update the org's desc, BZ 1114136 #4748

Merged
merged 1 commit into from Oct 21, 2014
Merged

refs #6463 - hammer was unable to update the org's desc, BZ 1114136 #4748

merged 1 commit into from Oct 21, 2014

Conversation

komidore64
Copy link
Contributor

No description provided.

@daviddavis
Copy link
Contributor

I know you're just fixing a bug but the api doc is very weird for this action. The update action has description and organization[name] as params. I'm not quite sure what the solution is but I think that users will be very confused by this.

@komidore64
Copy link
Contributor Author

@daviddavis i agree, but this is the api that we shipped with v2, so i'm not sure how much of it we can change (without moving to a v3).

for instance, i would consider moving a param from a nested location to an unnested location to be a breaking change.

@jlsherrill
Copy link
Member

This was never working correct?

If not, then there really isn't a worry about 'breaking' updating of description. The doc can be wrong as well as the code, to me in this case both are wrong and can be fixed. If the user previously could update the description with just passing 'description' I'd probably disagree.

there may be other implications I'm not seeing, so feel free to point those out :)

@komidore64
Copy link
Contributor Author

@jlsherrill good point. okay. i fixed the docs instead of making the code work for incorrect docs.

@komidore64
Copy link
Contributor Author

@jlsherrill @daviddavis plx2review

@jlsherrill
Copy link
Member

ACK from me, @daviddavis ?

@daviddavis
Copy link
Contributor

ACK

komidore64 added a commit that referenced this pull request Oct 21, 2014
…ptification-station

refs #6463 - hammer was unable to update the org's desc, BZ 1114136
@komidore64 komidore64 merged commit 773d9c6 into Katello:master Oct 21, 2014
@komidore64 komidore64 deleted the rmi6463-organization-desccriptification-station branch October 21, 2014 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants