Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #7979 - adding better error reporting for repo enable ui #4753

Merged
merged 1 commit into from Oct 20, 2014

Conversation

jlsherrill
Copy link
Member

This adds better messages for:

  • Fetching the list of available repositories for a repo set
  • Enabling a repo

%span.errors
%br
%i.icon-exclamation-sign
= _("There was an error attempting to enable or disable this repository: %s") % error_message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about putting the error_message text into a <pre></pre> to offset it a little more from the initial text? Should make copy/pasting the actual error message easier as well if a use rneeds to.

@ehelms
Copy link
Member

ehelms commented Oct 17, 2014

When I drilled down to enabling an actual repository I ended up with a link to /foreman_tasks/dynflow. While when it failed enabling a repository set it provided me a proper task link.

@jlsherrill
Copy link
Member Author

@ehelms correct, there's not really a way for us to grab the task due to the way the code is structured. I didn't want to re-write the enable repo task just for this legacy page.

@ehelms
Copy link
Member

ehelms commented Oct 17, 2014

@jlsherrill That's fine, but it's redirecting me to '/foreman_tasks/dynflow' which may not be enabled in all cases?

@jlsherrill
Copy link
Member Author

ohhhh right, that should be /foreman_tasks/tasks/ will fix

@jlsherrill
Copy link
Member Author

@ehelms updated link to tasks list and put error in pre tag

@ehelms
Copy link
Member

ehelms commented Oct 17, 2014

ACk

jlsherrill added a commit that referenced this pull request Oct 20, 2014
 fixes #7979 - adding better error reporting for repo enable ui
@jlsherrill jlsherrill merged commit bc5d7f6 into Katello:master Oct 20, 2014
@jlsherrill jlsherrill deleted the 7979 branch October 20, 2014 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants