Fixes #8113 - Docker Tags now displayed in the UI #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </span> | ||
| </div> | ||
|
|
||
|
|
There was a problem hiding this comment.
Why the blank lines here?
parthaa
force-pushed
the
docker-tags
branch
2 times, most recently
from
389fd8b
to
b5378a3
Compare
| { | ||
| :docker_image => repo.docker_images.count, | ||
| :docker_tag => repo.docker_tags.count, | ||
| :rpm => repo.package_count, |
There was a problem hiding this comment.
Why do you have a field for packages and a field for rpms?
There was a problem hiding this comment.
because @ehelms and @jlsherrill wanted it
|
What about updating the commit message to something more like |
Content unit counts will now also show information on Docker Tags
|
ACK for me, @daviddavis can have final say |
|
ACK |
parthaa
added a commit
that referenced
this pull request
Dec 2, 2014
Fixes #8113 - Docker Tags now displayed in the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content unit counts will now also show information on Docker Tags