Refs #7883: Adds repository filter to tabs on content view version detai... #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires - #4795 and Katello/bastion#15 |
|
|
||
| $scope.version.$promise.then(function () { | ||
| angular.forEach($scope.version.repositories, function (repository) { | ||
| $scope.repositories.push(repository); |
There was a problem hiding this comment.
why wouldn't you just do $scope.repositories = $scope.version.repositories ?
…sion details. This adds the ability to filter the package, errata and package group list for a content view version by repository.
|
@jlsherrill updated |
|
APJ and pending an issue opened to for the 'filter' to handle longer names more gracefully |
ehelms
added a commit
that referenced
this pull request
Nov 14, 2014
Refs #7883: Adds repository filter to tabs on content view version detai...
ehelms
added a commit
to ehelms/katello
that referenced
this pull request
Jan 11, 2016
ehelms
added a commit
that referenced
this pull request
Jan 12, 2016
Fixes #4796: Use Patternfly from Foreman core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ls.
This adds the ability to filter the package, errata and package group list
for a content view version by repository.