Fixes #7845 - Allows user to delete custom product #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamruzicka This worked for me. We have already released this API return format so I don't think we should change it at this point. If anything though, it would make the most sense to return the IDs IMO. I'm good to ack and merge this, just let me know. |
adamruzicka
force-pushed
the
7845-delete-custom-product
branch
2 times, most recently
from
e65a6ea
to
8f27ed0
Compare
|
@adamruzicka can you squash commits please? |
|
For a custom product in an existing content view, I am seeing the remove product button appearing which it shouldn't. |
adamruzicka
force-pushed
the
7845-delete-custom-product
branch
from
8f27ed0
to
635d535
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
Looks good, thanks @adamruzicka ! ACK and merging |
ehelms
added a commit
that referenced
this pull request
Dec 4, 2014
Fixes #7845 - Allows user to delete custom product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.