New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8626: ensure errata icons line up, BZ 1171310. #4862
Conversation
The icons are wrapping on the content host page for me with the last number dipping down to the line below but the icon staying above. I also am less of a fan of the icon being on the left again. Couldn't you do fixed-width containers with icons on the right and text-align: right ? |
@ehelms can you provide a screenshot please? |
@ehelms updated. |
@ehelms updated. |
@@ -33,3 +33,9 @@ html.custom-information { | |||
padding: 5px; | |||
} | |||
} | |||
|
|||
#content-hosts-table .errata-count { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do some sort of table.errata-count
styling so that this doesn't introduce an ID and could be re-used elsewhere if needed in a table?
The alignment in the table is just pixels off when the second row is forced by wrapping, however, not enough for me to hold this up. Just that one last small comment. |
The errata icons were not lining up on the list and details pages. This commit ensures that they line up, thus enhancing readability. http://projects.theforeman.org/issues/8626 https://bugzilla.redhat.com/show_bug.cgi?id=1171310
@ehelms updated. |
ACK |
Fixes #8626: ensure errata icons line up, BZ 1171310.
@ehelms @waldenraines My display is 1680 x 1050, and I get the wrapping, but there seems like there's lots of other free space in other columns (and between the errata icons). It seems like they should all be able to fit on one line? |
@stbenjam are you zoomed in past 100%? The fixed width between the errata icons are necessary to maintain the horizontal alignment of the icons and allow for four digit numbers. I'm not sure how we can have both horizontally aligned icons and no wrapping in all resolutions. It would definitely help if our columns were not equal width though, the subscription status column takes up way too much space, for example. |
The errata icons were not lining up on the list and
details pages. This commit ensures that they line up,
thus enhancing readability.
http://projects.theforeman.org/issues/8626
https://bugzilla.redhat.com/show_bug.cgi?id=1171310