Fixes #8519 - Bonus subs not being reindexed #4863
Conversation
|
@dustints, this pull request is currently not mergeable. Please rebase against the master branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running: This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Waiting on contributor
and removed
Needs testing
Needs re-review
Not yet reviewed
labels
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@thomasmckay should be working now |
| end | ||
|
|
||
| def add_pool_to_index(pool_id) | ||
| cp_pool = attempt_find_pool(pool_id) |
There was a problem hiding this comment.
What problem is this solving?
There was a problem hiding this comment.
@thomasmckay sometimes I get the message before the pool is available in candlepin...so when I query the pool in cp, it would throw a ResourceNotFound error...it was causing end-to-end testing to be inconsistent.
Bonus subscriptions aren't being reindexed since the handler was only watching for entitlements that got created/deleted. Handler should be watching pool create/delete.
|
@thomasmckay updated, after retesting a few times, that bit of logic isn't needed. |
|
ack |
Fixes #8519 - Bonus subs not being reindexed
Bonus subscriptions aren't being reindexed since the handler was only
watching for entitlements that got created/deleted. Handler should be
watching pool create/delete.