New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8668: Hide 'Server' kickstart repositories from enablement. #4867
Conversation
…ent. This also moves kickstart repositories to their own tab similar to other 'types' and to make them easier to locate.
repos = task.output[:results] | ||
|
||
repos = repos.select do |repo| | ||
repo[:path].include?('kickstart') ? !repo[:substitutions][:releasever].include?('Server') : true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this will ever matter, but I think it'd be better if you use the same comparison here as in the helper (on repo[:name]
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, disregard, repos' field is called repo_name, and the helper is looking at products anyway.
How do we handle the case where XServer repos are already enabled? Maybe change the logic on filtering to show 6Server if it's already enabled, so users can choose to disable it later. |
Good point! I think that makes sense to show if enabled for existing use cases. |
Updated. |
Thanks, found one more thing though: they're still usable in the API/hammer:
|
Updated. |
ACK |
Fixes #8668: Hide 'Server' kickstart repositories from enablement.
This also moves kickstart repositories to their own tab similar to
other 'types' and to make them easier to locate.