Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8668: Hide 'Server' kickstart repositories from enablement. #4867

Merged
merged 1 commit into from Dec 15, 2014

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 11, 2014

This also moves kickstart repositories to their own tab similar to
other 'types' and to make them easier to locate.

…ent.

This also moves kickstart repositories to their own tab similar to
other 'types' and to make them easier to locate.
repos = task.output[:results]

repos = repos.select do |repo|
repo[:path].include?('kickstart') ? !repo[:substitutions][:releasever].include?('Server') : true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this will ever matter, but I think it'd be better if you use the same comparison here as in the helper (on repo[:name])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, disregard, repos' field is called repo_name, and the helper is looking at products anyway.

@stbenjam
Copy link
Contributor

How do we handle the case where XServer repos are already enabled? Maybe change the logic on filtering to show 6Server if it's already enabled, so users can choose to disable it later.

@ehelms
Copy link
Member Author

ehelms commented Dec 11, 2014

Good point! I think that makes sense to show if enabled for existing use cases.

@ehelms
Copy link
Member Author

ehelms commented Dec 11, 2014

Updated.

@stbenjam
Copy link
Contributor

Thanks, found one more thing though: they're still usable in the API/hammer:

stbenjam@katello-dev ~/hammer-cli (bbd1c35*) $ bundle exec bin/hammer -u admin -p changeme repository-set available-repositories --product-id 8 --id 1951
-----------------------------------------------------------|--------|---------|--------
NAME                                                       | ARCH   | RELEASE | ENABLED
-----------------------------------------------------------|--------|---------|--------
[snip]
Red Hat Enterprise Linux 5 Server Kickstart i386 5Server   | i386   | 5Server | no
Red Hat Enterprise Linux 5 Server Kickstart ia64 5Server   | ia64   | 5Server | no
Red Hat Enterprise Linux 5 Server Kickstart x86_64 5Server | x86_64 | 5Server | no
-----------------------------------------------------------|--------|---------|--------

@ehelms
Copy link
Member Author

ehelms commented Dec 12, 2014

Updated.

@stbenjam
Copy link
Contributor

ACK

ehelms added a commit that referenced this pull request Dec 15, 2014
Fixes #8668: Hide 'Server' kickstart repositories from enablement.
@ehelms ehelms merged commit 0957647 into Katello:master Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants