Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9219: close details pane when cancelling content host selection. #4980

Merged
merged 1 commit into from
Feb 9, 2015

Conversation

waldenraines
Copy link
Contributor

@ehelms
Copy link
Member

ehelms commented Feb 5, 2015

Why close the entire pane as opposed to returning to the list?

@waldenraines
Copy link
Contributor Author

Why close the entire pane as opposed to returning to the list?

What's the difference? Which list? We are returning to the errata list by closing the pane.

@ehelms
Copy link
Member

ehelms commented Feb 5, 2015

Sorry, the list of content hosts for that specific errata. So I am viewing the content host list for an errata, I click a few, click apply and then click cancel and I am taken back to theerrata index list? Why wouldn't it take me back to the content host list for that errata?

@waldenraines
Copy link
Contributor Author

Sorry, the list of content hosts for that specific errata. So I am viewing the content host list for an errata, I click a few, click apply and then click cancel and I am taken back to theerrata index list? Why wouldn't it take me back to the content host list for that errata?

No. If you click cancel on the confirm page you are taken back to the content host list. This issue is about clicking cancel on the content host list itself. If the user clicks cancel on the content host selection page they are now taken back to the errata list.

The issue was that both cancel buttons were using transitionBack() so the result was going back and forth between the confirm and content host page if you clicked cancel on each page.

@ehelms
Copy link
Member

ehelms commented Feb 9, 2015

ACK

waldenraines pushed a commit that referenced this pull request Feb 9, 2015
Fixes #9219: close details pane when cancelling content host selection.
@waldenraines waldenraines merged commit c9943e1 into Katello:master Feb 9, 2015
@waldenraines waldenraines deleted the 9219 branch February 9, 2015 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants