New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #9839: show no rows message if table isn't working BZ 1203851. #5122
Conversation
would it be possible to implement this logic in nutupane/details_nutupane so anything using that would get the logic automatically? I know we have a lot of places that don't use details_nutupane that should, but it would be nice for this to be handled automatically if you are |
I suppose we could use an angular-block for the places that use nutupane and details nutupane but we'd still have to specify the message on each page. Thoughts on that approach? |
@waldenraines yeah, i'm find with the message specified on each page, i'd just prefer the logic to show it be somewhere else. Otherwise I think it will get lost when creating new pages |
…03851. Only show the message about not having any items on a nutupane table if the table isn't currently working. http://projects.theforeman.org/issues/9839 https://bugzilla.redhat.com/show_bug.cgi?id=1203851 Requires Katello/bastion#55
@jlsherrill updated, see also Katello/bastion#55 |
ACK pending new release of bastion and version requirement bump in the katello.gemspec |
Nevermind, cherry picked to 0.30 |
Fixes #9839: show no rows message if table isn't working BZ 1203851.
Only show the message about not having any items on a nutupane table
if the table isn't currently working.
http://projects.theforeman.org/issues/9839
https://bugzilla.redhat.com/show_bug.cgi?id=1203851
Requires Katello/bastion#55