Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9839: show no rows message if table isn't working BZ 1203851. #5122

Merged
merged 1 commit into from Mar 23, 2015

Conversation

waldenraines
Copy link
Contributor

Only show the message about not having any items on a nutupane table
if the table isn't currently working.

http://projects.theforeman.org/issues/9839
https://bugzilla.redhat.com/show_bug.cgi?id=1203851

Requires Katello/bastion#55

@jlsherrill
Copy link
Member

would it be possible to implement this logic in nutupane/details_nutupane so anything using that would get the logic automatically?

I know we have a lot of places that don't use details_nutupane that should, but it would be nice for this to be handled automatically if you are

@waldenraines
Copy link
Contributor Author

I suppose we could use an angular-block for the places that use nutupane and details nutupane but we'd still have to specify the message on each page. Thoughts on that approach?

@jlsherrill
Copy link
Member

@waldenraines yeah, i'm find with the message specified on each page, i'd just prefer the logic to show it be somewhere else. Otherwise I think it will get lost when creating new pages

…03851.

Only show the message about not having any items on a nutupane table
if the table isn't currently working.

http://projects.theforeman.org/issues/9839
https://bugzilla.redhat.com/show_bug.cgi?id=1203851

Requires Katello/bastion#55
@waldenraines
Copy link
Contributor Author

@jlsherrill updated, see also Katello/bastion#55

@jlsherrill
Copy link
Member

ACK pending new release of bastion and version requirement bump in the katello.gemspec

@jlsherrill
Copy link
Member

Nevermind, cherry picked to 0.30
ACK

waldenraines pushed a commit that referenced this pull request Mar 23, 2015
Fixes #9839: show no rows message if table isn't working BZ 1203851.
@waldenraines waldenraines merged commit 14367b0 into Katello:master Mar 23, 2015
@waldenraines waldenraines deleted the 9839 branch March 23, 2015 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants