Fixes 10334,BZ1217694 - Working indicator in products repository list #5268
Conversation
|
A thought, if we converted this repository list to the details-nutupane like we have in other places (and thus enable search and what not) we should get loading and other functionality all in one. Thoughts? |
|
I somehow missed details-nutupane. It would probably be better to use it. I'll rewrite it and report back |
|
[test] |
|
@adamruzicka it looks like there are various instances of the HTML not being aligned properly |
|
@ehelms You mean the buttons? I tried investigating what would be needed to align them correctly. Apparently the buttons and the "x Selected" text are wrapped in a div with class "col-sm-4" which just doesnt give them enough space to be aligned properly. With that class removed it looks like this but it might break other pages using details-nutupane |
|
@adamruzicka sorry, I meant the raw HTML when viewing the file itself -- in some cases things are indented 2 spaces, some 4 and some not at all. |
|
oh, sorry for misunderstanding, I'll fix that (along with the failing tests) tomorrow morning |
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
| @@ -49,8 +49,8 @@ angular.module('Bastion.products').controller('ProductRepositoriesController', | |||
| $scope.errorMessages = []; | |||
|
|
|||
| $scope.checksums = [{name: translate('Default'), id: null}, {id: 'sha256', name: 'sha256'}, {id: 'sha1', name: 'sha1'}]; | |||
| $scope.repositoriesTable = repositoriesNutupane.table; | |||
| $scope.repositoriesTable.removeRow = repositoriesNutupane.removeRow; | |||
| $scope.detailsTable = repositoriesNutupane.table; | |||
There was a problem hiding this comment.
need to add:
repositoriesNutupane.masterOnly = true;
otherwise it throws javascript errors
There was a problem hiding this comment.
I haven't met any errors even without this line. Could you please check it again with the latest commit if you still see any errors?
There was a problem hiding this comment.
you get this error when performing a search
|
Missed a reference to repositoriesTable (that was renamed to detailsTable in order to use the template): I got a traceback after creating a repo due to it |
adamruzicka
force-pushed
the
10334-product_repository_loading
branch
from
014fb23
to
183f54b
Compare
|
@jlsherrill fixed the references I missed previously |
|
@adamruzicka all looks good to me, mind squashing your commits? |
adamruzicka
force-pushed
the
10334-product_repository_loading
branch
from
183f54b
to
89ac737
Compare
|
@jlsherrill Squashed, thanks |
ehelms
added
Ready for merge
and removed
Needs re-review
Needs testing
Not yet reviewed
labels
adamruzicka
force-pushed
the
10334-product_repository_loading
branch
from
89ac737
to
aa507d3
Compare
|
@jlsherrill fixed the search traceback |
|
[test] |
adamruzicka
force-pushed
the
10334-product_repository_loading
branch
from
aa507d3
to
cbaa0a8
Compare
|
@jlsherrill awaiting a final ACK/merge from you as the original reviewer |
|
ACK thanks @adamruzicka ! |
…ading Fixes 10334,BZ1217694 - Working indicator in products repository list
gif here