Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

841857 - fixing LDAP logins in katello mode #535

Merged
merged 2 commits into from
Aug 29, 2012
Merged

841857 - fixing LDAP logins in katello mode #535

merged 2 commits into from
Aug 29, 2012

Conversation

jsomara
Copy link
Contributor

@jsomara jsomara commented Aug 28, 2012

A couple things:

  1. Someone please verify the User.current assignments; they work but I want to make sure they do not introduce any unwanted side effects. The tests pass. The User_Session controller also subsequently modifies user.current so the second assignment might not be necessary, but my thought was to limit the scope of the "hidden user" as much as possible
  2. This fix is dependent on a UI fix in converge-ui as well, will update with a comment once that pull request goes in

@jsomara
Copy link
Contributor Author

jsomara commented Aug 28, 2012

https://github.com/Katello/converge-ui/pull/60

ehelms
ehelms reviewed Aug 28, 2012
View reviewed changes
src/app/models/user.rb
User.create!(:username => username)
u = User.create!(:username => username)
User.current = u
u
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types of returns always look like typos to me....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like return u

@knowncitizen
Copy link
Contributor

Honk Honk Beep Beep.

knowncitizen added a commit that referenced this pull request Aug 29, 2012
@knowncitizen
Merge pull request #535 from jsomara/841857
39ebddf 
841857 - fixing LDAP logins in katello mode
@knowncitizen knowncitizen merged commit 39ebddf into Katello:master Aug 29, 2012
ehelms pushed a commit that referenced this pull request Apr 27, 2013
@knowncitizen
Merge pull request #535 from jsomara/841857
07f9762 
841857 - fixing LDAP logins in katello mode
@RoshanRajapakse RoshanRajapakse mentioned this pull request Nov 27, 2023
Open
@RoshanRajapakse RoshanRajapakse mentioned this pull request Feb 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jsomara @knowncitizen @ehelms