Fixes #10430: Add ability to run a sync plan at any time. #5357
Conversation
| products = item_search(Product, params, options) | ||
| respond_for_index(:collection => products) | ||
| options = {:includes => [:sync_plan, :provider], :resource_class => Product} | ||
| respond_for_index(:collection => scoped_search(products, :name, :desc, options), :template => '../products/index') |
There was a problem hiding this comment.
errrrr did this get missed in the scoped search conversion?
There was a problem hiding this comment.
if thats the case, mind deleting these three lines:
I know the first one isn't required, i think the 2nd might not anymore either.
There was a problem hiding this comment.
Appears that it did get missed, I removed those lines you mentioned.
ehelms
force-pushed
the
fixes-10430
branch
3 times, most recently
from
7cf8c61
to
bd80038
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
Updated to remove the errant |
ehelms
force-pushed
the
fixes-10430
branch
4 times, most recently
from
18070d5
to
7421922
Compare
|
@jlsherrill This is finally ready for re-review after fixing some tests. |
|
@ehelms works well, one small quirk. If i try to run a sync plan against an a sync plan with no products or a sync plan with only empty products, the server returns an ISE and the UI does not display anything. We probably need to check for that case and display the appropriate error. |
|
@jlsherrill updated this based upon ForemanTasks now raising bulk action exceptions |
|
The current message i get when trying to run an empty sync plan is: 'ERF42-8280 [Foreman::Exception]: Empty bulk action' wouldn't a more appropriate controller action specific message make more sense? |
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@jlsherrill Updated to include better message |
ehelms
force-pushed
the
fixes-10430
branch
2 times, most recently
from
7b051e8
to
e8c2118
Compare
|
Tests are now passing |
|
ACK |
Fixes #10430: Add ability to run a sync plan at any time.
No description provided.