Fixes #11294: Prevent top level constant warning from Logging.

[ehelms]

The warning "warning: toplevel constant Logging referenced by
Katello::Foreman::Logging" appears many times throughout test runs.
Further it may be the cause of intermittent failures on Jenkins that
seem to result from the customized fixture setup being unset with
respect to referencing the Foreman fixtures.

[ehelms]

As with most intermittent failures, this is a hard one to recreate and I am speculating the fix as this didn't happen prior to logging and if oyu look at the error output the warning appears before the failure.

[domcleal]

As with most intermittent failures, this is a hard one to recreate and I am speculating the fix as this didn't happen prior to logging and if oyu look at the error output the warning appears before the failure.

It also happens in passing tests, e.g. http://ci.theforeman.org/job/test_katello_core/14564/database=postgresql,ruby=1.9.3/console, and happened much earlier in one of the failing tests linked in the ticket (http://ci.theforeman.org/job/test_katello_core/14563/database=postgresql,ruby=1.9.3/console).

[stbenjam]

I don't see the referenced errors in the logs for this test, but there's other references to Foreman::Logging, even in this file.

Should we make them all explicitly at the top level? To avoid this happening again in some other new test.

[ehelms]

Wondering if I should make this change under the guise of another issue targeted specifically at this, and over time see if the issue remains and revisit. I cannot seem to recreate it locally, and I have theories but no solid solutions yet of how to potentially make the fixture loading more robust.

[stbenjam]

Is the Logging warning causing the fixture loading error? Or is it something else?

Just had a failure with it:
http://ci.theforeman.org/job/test_katello_pr_core/database=postgresql,ruby=1.9.3/22/console

[ehelms]

That's what I am getting at - I am not sure the cause, but I'd like to at least rule this out (and its a worth while fix as this warning is annoying)

[stbenjam]

Seems fine to me, I was just saying what about other instances of Foreman::Logging? I do see in my failure it's only the line you changed triggering it, but might as well be consistent with all the references to it.

[ehelms]

I created a new issue targeted strictly at fixing the Logging warnings and updates this PR to point to that for now. I'd like to get this fix in and then monitor to see if the intermittent failure continues on Jenkins.

[stbenjam]

APJ