fixes #11210 - Distribution API endpoint deprecation #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to add |
johnpmitsch
force-pushed
the
distro_api_deprecation
branch
from
a7ea5c9
to
4ff13af
Compare
|
Can you include the |
| @@ -24,6 +25,10 @@ def show | |||
|
|
|||
| private | |||
|
|
|||
| def deprecated | |||
| ::Foreman::Deprecation.api_deprecation_warning("it will be changed in 2.4, where Distribution information will be included in /repositories/:repository_id") | |||
There was a problem hiding this comment.
I'd say in Katello 2.4 so its clear when looking at the logs.
johnpmitsch
force-pushed
the
distro_api_deprecation
branch
from
4ff13af
to
462fa1b
Compare
|
LGTM - @jlsherrill mind reviewing as well since this is our first attempt at doing this sort of deprecation? |
|
ACK from me |
|
ACK! Thanks @johnpmitsch |
ehelms
added a commit
that referenced
this pull request
Jul 29, 2015
fixes #11210 - Distribution API endpoint deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distribution information is being shown in /repositories/:repository_id endpoint starting in 2.4, a deprecation warning needs to be added to 2.3