Fixes #11330: message on errata list if errata exist, BZ 1242943. #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Erratum.queryUnpaged({'organization_id': CurrentOrganization}, function (result) { | ||
| $scope.errataCount = result.total; | ||
| }); | ||
|
|
There was a problem hiding this comment.
I have many thousands of errata, and this slows the page down about 1000% for me :-(
Rendering the RABL generates so many SQL queries.
There was a problem hiding this comment.
I suppose I could add yet another parameter or an API to just return the count of the errata. I was wanting to avoid that because it seems silly.
Any other suggestions?
There was a problem hiding this comment.
I just realized I was using queryUnpaged()! Let me try with queryPaged() that shouldn't slow it down as much.
stbenjam
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
Show a different message if errata exists in an organization but is hidden by filters. http://projects.theforeman.org/issues/11330 https://bugzilla.redhat.com/show_bug.cgi?id=1242943
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@stbenjam updated. Try that please, it should be faster. |
|
Much better! ACK |
waldenraines
pushed a commit
that referenced
this pull request
Aug 12, 2015
Fixes #11330: message on errata list if errata exist, BZ 1242943.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a different message if errata exists in an organization but is
hidden by filters.
http://projects.theforeman.org/issues/11330
https://bugzilla.redhat.com/show_bug.cgi?id=1242943