834013 - return releaseVer as part of consumer json #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -410,7 +410,7 @@ | |||
| @sys.stub(:guest => 'false', :guests => []) | |||
| Resources::Candlepin::Consumer.should_receive(:update).once.with(uuid, {}, nil, nil, nil, "1.1", nil, anything).and_return(true) | |||
| put :update, :id => uuid, :releaseVer => "1.1" | |||
| response.body.should == @sys.to_json | |||
There was a problem hiding this comment.
The 'releaseVer' value is added to the system json in the call and is not part of the system itself.
There was a problem hiding this comment.
but shouldn't the API call still return the system object as JSON which I would imagine the should is for?
|
ACK |
thomasmckay
pushed a commit
that referenced
this pull request
Sep 6, 2012
834013 - return releaseVer as part of consumer json
thomasmckay
pushed a commit
that referenced
this pull request
Apr 27, 2013
834013 - return releaseVer as part of consumer json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.