fixes #12264 - regenerating .rubocop_todo.yml to remove warnings #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Offense count: 586 | ||
| # Offense count: 1 | ||
| Lint/UselessAssignment: | ||
| Enabled: false |
There was a problem hiding this comment.
I probably would fix the one error rather than disable this cop.
|
It also looks like |
|
@daviddavis okay cool. i'll address your comments. thanks! |
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
APJ + commit squash. |
daviddavis
added
Waiting on contributor
and removed
Needs re-review
Needs testing
labels
Foreman has Rubocop's version pinned to 0.28.0. At some point it seems that we generated a `.rubocop_todo.yml` for 0.30.x which has a different set of cops than 0.28.0. This was causing our Rubocop runs to throw warnings about unknown cops. It hasn't caused any problems, other than simply being annoying. In this commit, I've regenerated `.rubocop_todo.yml` so that it's been generated by 0.28.0. This should remove those pesky 'unrecognized cops' errors.
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@daviddavis squashed |
|
ACK |
daviddavis
added a commit
that referenced
this pull request
Nov 16, 2015
fixes #12264 - regenerating .rubocop_todo.yml to remove warnings
|
thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreman has Rubocop's version pinned to 0.28.0. At some point
it seems that we generated a
.rubocop_todo.ymlfor 0.30.x which has adifferent set of cops than 0.28.0. This was causing our Rubocop runs to
throw warnings about unknown cops. It hasn't caused any problems, other
than simply being annoying.
In this commit, I've regenerated
.rubocop_todo.ymlso that it's beengenerated by 0.28.0. This should remove those pesky 'unrecognized cops'
errors.