Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5387 - Remove default content views for dev and staging in the… #5566

Merged
merged 1 commit into from Nov 5, 2015

Conversation

johnpmitsch
Copy link
Contributor

… tests

These fixtures are no longer needed because they are multiple versions of a default content view. A default content view should only have one version. Tests are updated accordingly


debugger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debuggin' the githubs i see!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad all, you caught me opening a PR without running rubocop :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more trying to point out the wonderful soul who contributed the debugger cop to rubocop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He is a wise man

@johnpmitsch johnpmitsch force-pushed the remove_fixtures branch 6 times, most recently from 9590aa0 to 41bcb64 Compare November 5, 2015 14:34
@daviddavis
Copy link
Contributor

ACK from me

@jlsherrill
Copy link
Member

ACK

johnpmitsch pushed a commit that referenced this pull request Nov 5, 2015
Fixes #5387 - Remove default content views for dev and staging in the…
@johnpmitsch johnpmitsch merged commit 8524143 into Katello:master Nov 5, 2015
@johnpmitsch johnpmitsch deleted the remove_fixtures branch November 5, 2015 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants