Fixes #12758: Fix seeds test to not need DatabaseCleaner #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parthaa @daviddavis could you please review this? My testing on an EL6 devel box indicated this would fix the issue. Currently, I have test_katello_core locked to EL7 boxes only so I can relax that in hopes this hits as an EL6 box, or you can test it out yourselves. |
| class SeedsTest < ActiveSupport::TestCase | ||
| setup do | ||
| # Disable AR transactional fixtures as we use DatabaseCleaner's truncation | ||
| # to empty the DB of fixtures for testing the seed script |
There was a problem hiding this comment.
I think we can remove these comments?
|
ACK from me |
|
apj |
This fixes failures that occur on Postgres 8.4 from primary key failures.
|
Comments removed |
ehelms
added a commit
that referenced
this pull request
Dec 10, 2015
Fixes #12758: Fix seeds test to not need DatabaseCleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failures that occur on Postgres 8.4 from primary key
failures.