Fixes #13214: Add missing asset to precompile list #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix the test failures -- manual run of it http://ci.theforeman.org/job/test_katello_pull_request/8045/ |
|
ACK |
|
Gah sorry, is this because of theforeman/foreman#3057 ? 👍 if tests are green. FTR that PR enables the same setting as we have in development, but in the test env too, so we figure out any missing assets ASAP. |
|
I don't mind the change, its a good one -- just don't like the merging of PRs that show broken status that are merged. |
|
Updated after finding further errors but this also identified issues with foreman-docker which will be required for our tests to pass. I have opened a PR with fixes: theforeman/foreman_docker#137 |
|
ACK again |
ehelms
added a commit
that referenced
this pull request
Jan 15, 2016
Fixes #13214: Add missing asset to precompile list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.