Fixes #13208 - Enabled 'Mirror On Sync' for repositories #5709
Conversation
| @@ -5,6 +5,7 @@ extends 'katello/api/v2/common/timestamps' | |||
|
|
|||
| attributes :content_type | |||
| attributes :docker_upstream_name | |||
| attributes :mirror_on_syncP | |||
There was a problem hiding this comment.
I could ve sworn I tested this!. Oh well must ve been an accidental typo
ehelms
added
Waiting on contributor
Needs testing
and removed
Needs testing
Not yet reviewed
labels
parthaa
force-pushed
the
mirror-on-sync
branch
from
1a646ed
to
bc76b79
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
| type="checkbox" | ||
| tabindex="8"/> | ||
| <h6 translate> | ||
| Selecting this option will result in content that are no longer part of the upstream repository being removed during synchronization. |
There was a problem hiding this comment.
Fix subject/verb agreement. contents are or content is.
parthaa
force-pushed
the
mirror-on-sync
branch
4 times, most recently
from
1a94c72
to
c4b64c6
Compare
|
I'm actually starting to question whether we should default to the mirroring to 'true' for new repositories. Maybe an email is in order? |
|
What are your thoughts on why not to have that be the default? |
parthaa
force-pushed
the
mirror-on-sync
branch
from
c4b64c6
to
688046f
Compare
|
@jlsherrill waiting on your response @parthaa needs a rebase |
|
you know honestly the next day i couldn't even remember and still can't really. Feel free to ignore :) |
|
Does this require 2.8? If not, a rebase and tests passing and this will be good to go. |
|
waiting on https://pulp.plan.io/issues/1621 to get to the nightly |
parthaa
force-pushed
the
mirror-on-sync
branch
from
688046f
to
c838533
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@ehelms @jlsherrill updated. Few merge conflicts and cassette regeneration. I was selective on the cassettes and didnt generate all. Anyway the cassettes are in a separate commit. |
|
LGTM - @jlsherrill ? |
|
I'm good with the code. I think we should wait for a new beta so nightly isn't completely broken out of the box though. Hopefully will only be a ~day? |
|
New Pulp beta has been pushed to our nightly repositories. Does this need a cassette re-run or is it GTG? |
|
Gtg ack
|
Added code to mirror the upstream feed repository by default. Scenario: If feed had packages A1, B1 at some point and the katello host repo synced this , it would have A1,B1 Now if the feed updated its repo and now has A2, B1 and the user resynced, the host repo would now have A1,A2, B1. This commit adds the mirroring option and enables it by default
parthaa
force-pushed
the
mirror-on-sync
branch
from
c838533
to
a0bc42f
Compare
|
@jlsherrill @ehelms there were some merge conflicts.. Hopefully they worked out.. |
Fixes #13208 - Enabled 'Mirror On Sync' for repositories
Added code to mirror the upstream feed repository by default.
Scenario:
If feed had packages A1, B1 at some point and the katello host repo synced this , it would have A1,B1
Now if the feed updated its repo and now has A2, B1 and the user resynced, the host repo would now have A1,A2, B1.
This commit adds the mirroring option and enables it by default