Fixes #13566 - Added TaskGroup support for errata regeneration

[parthaa]

No description provided.

[parthaa]

Needed for pulp 2.8

[ehelms]

Could probably drop this blank line and the one # line above it to combine the two.

[ehelms]

Missing tests

[parthaa]

Missing tests
@ehelms Will add that, but I actually had design questions on this. So @jlsherrill suggested combining logic in AbstractAsyncTaskGroup and AbstractAsyncTask . And add code that says "if group_id was specified do Task Group else if task id shows up do Task, else if pulp_task show so pulp_taskstuff else of pulp_taskgroup shows up do TaskGroup stuff". This will mean actions who extend AbstractAsyncTask dont have to be changed to AbstractAsyncTaskGroup (when pulp moves more tasks in that direction). What do you think .

[jlsherrill]

yeah my goal was that a developer doesn't need to know which 'type' of async return output for a given call is made, abstract_async_task will just handle it.

[parthaa]

needs -> Katello/runcible#167

[ehelms]

@parthaa should this go into 3.0?

[jlsherrill]

@parthaa ????

[parthaa]

yeah my goal was that a developer doesn't need to know which 'type' of async return output for a given call is made, abstract_async_task will just handle it.

@jlsherrill @ehelms I am not sure I like the idea of complicating the AbstractSyncTask. I find my changes easy enough to make if in the future pulp adds task groups support ..

[jlsherrill]

seeing an error when syncing a repo:

undefined method `+' for {"group_id"=>"74dca57f-9d6a-4afa-985c-0f2e0796919d"}:Hash

---
- "/home/vagrant/git/katello/app/lib/actions/pulp/abstract_async_task_group.rb:63:in
  `external_task='"
- "/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.10/lib/dynflow/action/polling.rb:98:in
  `poll_external_task_with_rescue'"
- "/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.10/lib/dynflow/action/polling.rb:21:in
  `run'"
- "/home/vagrant/git/katello/app/lib/actions/pulp/abstract_async_task_group.rb:30:in
  `run'"
- "/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.10/lib/dynflow/action.rb:506:in
  `block (3 levels) in execute_run'"
- "/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.10/lib/dynflow/middleware/stack.rb:26:in
  `call'"
- "/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.10/lib/dynflow/middleware/stack.rb:26:in
  `pass'"
- "/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.10/lib/dynflow/middleware.rb:17:in
  `pass'"

[parthaa]

seeing an error when syncing a repo:

@jlsherrill Fixed

[jlsherrill]

Testing this, i can't seem to get errata applicability to work properly:

1. Create a product 'zoo'
2. Create a repo under the zoo product named 'zoo', pointed to https://jlsherrill.fedorapeople.org/fake-repos/needed-errata/
3. Install walrus-0.71-1.noarch from the above repo on a host
4. Register a host and assign it to the zoo product
5. Run 'subscription-manager refresh && yum repolist' on the client
6. Sync the zoo repo

Results: No errata show up as applicable and the raw status looks like:

pulp_task_group:
  group_id: c626742e-f170-4f68-b685-4ce7c350fb8e
  accepted: 0
  finished: 0
  running: 0
  canceled: 0
  waiting: 0
  skipped: 0
  suspended: 0
  error: 0
  total: 0
poll_attempts:
  total: 1
  failed: 0

I confirmed the repo is 'bound' properly to the host.

[jlsherrill]

Nevermind that issue is: https://pulp.plan.io/issues/1785

[jlsherrill]

[test]

[parthaa]

[test]

[jlsherrill]

ACK