Fixes #12952 - Disassociate proxy from content host before removing it #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,6 +212,9 @@ def get_systems_with_facts(systems) | |||
|
|
|||
| systems_to_remove.each do |system| | |||
| logger.info("Content Host #{system.uuid} doesn't have candlepin information, unregistering.") | |||
| system_proxy = SmartProxy.find_by_content_host_id(system.id) | |||
| system_proxy.content_host = nil | |||
| system_proxy.save | |||
There was a problem hiding this comment.
I think you need to check for nil here, as not every system will have an associated smart proxy.
On the content hosts migration, when a content host is going to be removed, it first needs to be disassociated from the proxy it belongs to. Otherwise it fails with the foreign_key problem mentioned in redmine.
|
@jlsherrill Updated, now it checks there's a proxy that uses the system in question during the migration |
|
ACK thanks @dLobatog ! |
jlsherrill
added a commit
that referenced
this pull request
Feb 23, 2016
Fixes #12952 - Disassociate proxy from content host before removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the content hosts migration, when a content host is going to be
removed, it first needs to be disassociated from the proxy it belongs
to. Otherwise it fails with the foreign_key problem mentioned in
redmine.