Fixes #13910 - Auto populate env, cv on new host #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing Procedure
|
| lifecycle_environment = lifecycle_environment(host) | ||
| lifecycle_environment = lifecycle_environment(selected_host_group) if lifecycle_environment.nil? && selected_host_group.present? |
There was a problem hiding this comment.
I'm sensing some repeated logic between this and https://github.com/Katello/katello/pull/5814/files#diff-a29a1f54f7213ac056cf5af0631d90fcR45
|
This works as expected when I tested out the new hosts page 👍 |
|
@parthaa looks like this was already a bug http://projects.theforeman.org/issues/12899 |
Adds logic to auto populate env, cv on new hosts page when a host group is selected
parthaa
force-pushed
the
new-host-vanishing-acts
branch
from
43162ee
to
6840142
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@ehelms @johnpmitsch updated |
|
@jlsherrill updated |
|
ACK |
parthaa
added a commit
that referenced
this pull request
Mar 7, 2016
Fixes #13910 - Auto populate env, cv on new host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to auto populate env, cv on new hosts page when a host group
is selected