Fixes #10440: show error and success messages when creating GPG keys. #5891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| GlobalNotification.setErrorMessage("An error occurred while creating the GPG key: " + content.displayMessage); | ||
| $scope.errorMessages = [translate("An error occurred while creating the GPG key: ") + content.displayMessage]; |
There was a problem hiding this comment.
What's the reasoning behind not using a global notification here?
There was a problem hiding this comment.
Because to me it seems odd to put an error message in the global notification spot when the error is on the form itself. Showing the error right above the form calls attention to the form where the error is.
|
ACK |
waldenraines
pushed a commit
that referenced
this pull request
Mar 18, 2016
Fixes #10440: show error and success messages when creating GPG keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://projects.theforeman.org/issues/10440