Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #14293 - display subscription details for hypervisors #5907

Merged
merged 1 commit into from Mar 28, 2016

Conversation

thomasmckay
Copy link
Member

  • properly sets uuid on subscription_facet
  • check both host.hasContent() and host.hasSubscription() for details page
  • confirm presence of host.content to prevent js errors

@beav
Copy link
Contributor

beav commented Mar 22, 2016

this looks reasonable. What is the easiest way to test it out? Do I need to register w/ virt-who?

@beav
Copy link
Contributor

beav commented Mar 23, 2016

I tested this with #5910 but hit a 500 error when attempting to display the page

Here is how I tested:

  • install katello nightly from bats, register host to itself with subman
  • apply patches
  • run the following:
# sudo /usr/share/virt-whom/virt-whom -H hypervisor02.example.com:7BB6F404-F13D-11E5-85F0-39AEDC50F6B3 -e Library                                                     
INFO: Updated host: 8ae8d958-0907-4355-bcc1-506345b542de with guests: [7BB6F404-F13D-11E5-85F0-39AEDC50F6B3]
  • attempt to view hypervisor02 from content host list

After doing this, I got a 500 error, it appears that something is trying to call candlepin but not passing in the consumer UUID. I suspect that this error was there before the patches were applied.

Is there a different way to test these PRs?

@thomasmckay
Copy link
Member Author

I cannot reproduce your error:

  1. switched to branch
  2. ran virt-whom
  3. visited content hosts page and was able to select the hypervisor

@beav
Copy link
Contributor

beav commented Mar 28, 2016

ACK, my prior test was on a bats machine and I assume the issue was related to me hand-patching.

@thomasmckay thomasmckay merged commit 975a0b3 into Katello:master Mar 28, 2016
@thomasmckay thomasmckay deleted the 14293-hv-details branch March 28, 2016 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants