fixes #14351 - split host id parameter to remote execution controller #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk action tool delivers a comma-separated list of host ID's, so we need to turn it into an array. Otherwise, the .where query will still work but it only finds the first host in the list of ID's.
|
Thoughts on a test for this? |
|
The controller code isn't even loaded in rails unless REX is installed. Is it in the test environment? |
|
Yes, it would require the remote execution plugin to be present in order to test it. We might add that as devel dependency (or runtime if you want) and start better testing, but still, I would prefer to fix this as in a separate issue http://projects.theforeman.org/issues/14384 |
|
tested this, worked great. ACK from a user perspective |
|
WFM - ACK |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk action tool delivers a comma-separated list of host ID's, so we need
to turn it into an array. Otherwise, the .where query will still work but it
only finds the first host in the list of ID's.