fixes #14711 - ui: fix subscription -> associations -> content hosts #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an error that caused the following page not to render: Content -> Red Hat Subscriptions -> [subscription] -> Associations -> Content Hosts The change will display memory using dmi::memory::size to be consistent with how the memory is shown for individual content hosts at: Hosts -> Content Hosts -> [host] -> Details
|
Looks like we have some duplication of issues and PRs, although I think your fix might be more correct (http://projects.theforeman.org/issues/14219). Would you mind resolving them (marking duplicate etc) ? |
|
@ehelms, Per our chat, I closed the other PR and marked the corresponding redmine/bugzilla as duplicates. Thanks! |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an error that caused the following page not to render:
Content -> Red Hat Subscriptions -> [subscription] -> Associations -> Content Hosts
The change will display memory using dmi::memory::size to be consistent with how the memory is shown for individual content hosts at:
Hosts -> Content Hosts -> [host] -> Details