Fixes #14802 - Correctly determines if working with Host/Hostgroups page #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All I changed in all the erbs is "using_hostgroups_page" became "using_hostgroups_page?" |
parthaa
force-pushed
the
host-hostgroups
branch
from
6cc88f3
to
f6b7b21
Compare
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
parthaa
changed the title
|
@parthaa theforeman-bot is complaining because of the lack of whitespae around the '-'. Should be: |
parthaa
force-pushed
the
host-hostgroups
branch
from
f6b7b21
to
19e93be
Compare
parthaa
changed the title
Thanks |
|
Code looks fine to me, haven't tested it yet though |
parthaa
force-pushed
the
host-hostgroups
branch
from
19e93be
to
c327666
Compare
Prior to this commit the hosts and hostroups pages used the same erbs They were just identifying what constitutes a host page vs hostgroup page in the wrong manner. It used -> @host.nil? to determine this which doesnt work for all situations. This commit instead centralizes that logic in a nice helper and uses a simpler 'check the controller name' approach
parthaa
force-pushed
the
host-hostgroups
branch
from
c327666
to
91a406d
Compare
|
ACK from a user perspective. tested a series of provisioning use-cases with and without hostgroups as well as editing existing hosts and it properly assigned the media as selected. Also checked some error handling on empty fields, worked well after an update partha did |
|
ACK from code perspective. |
|
merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the hosts and hostroups pages used the same erbs
They were just identifying what constitutes a host page vs hostgroup
page in the wrong manner.
It used -> @host.nil? to determine this which doesnt work for all
situations.
This commit instead centralizes that logic in a nice helper and uses a
simpler 'check the controller name' approach