Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14807 - don't generate repo metadata when nothing was synced #5996

Closed
wants to merge 1 commit into from
Closed

Fixes #14807 - don't generate repo metadata when nothing was synced #5996

wants to merge 1 commit into from

Conversation

tstrachota
Copy link
Member

Turns off auto-publishing for yum repos in Pulp. Auto-publish always triggers metadata regenerate regardless of whether any updates are synced.

This PR adds action Pulp::Repository::Publish which conditionally publishes repos only if new content was downloaded.

DO NOT MERGE YET - tests are still missing

@jlsherrill
Copy link
Member

@tstrachota this was filed against a version when we generated node metadata and would sync that to the capsules every time. The current syncing mechanism uses the normal yum metadata which they have optimizations on to not regenerate if nothing changed I believe. I this this issue may be solved already.

@tstrachota
Copy link
Member Author

@jlsherrill from what I tested the metadata are always regenerated also in the latest version. Or at least timestamps on the files change.

@jlsherrill
Copy link
Member

@tstrachota yeah the metadata generate action still occurs, but (at least for yum) there is some optimization so its really quick (and yum is the only one that normally takes a long time).

You should be able to test this yourself. Sync a large-ish repo and monitor 'pulp-admin tasks' to see how long the publish task takes. Sync it a 2nd time and see how long it takes.

Previously we were using the pulp node feature to sync to the capsules and i bet that ignored the optimization that we have today.

@tstrachota
Copy link
Member Author

@jlsherrill ok, I'll need to try that, thanks!

@tstrachota
Copy link
Member Author

Closing the PR per discussion with @jlsherrill

@tstrachota tstrachota closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants