Fixes #14917: fix select all when adding erratum to an errata filter. #6015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select all functionality of the errata filter by erratum ID was completely broken after the rails 4 conversion. This commit fixes a couple of issues when adding erratum to a filter using the select all functionality. Also, fixes a couple of minor UI issues on the errata filter pages. http://projects.theforeman.org/issues/14917
|
After a conversation with @jlsherrill on IRC we have decided that we should try to make this API similar to the other bulk APIs. I'm going to give this a shot. |
waldenraines
added
Waiting on contributor
Not yet reviewed
and removed
Needs testing
Not yet reviewed
labels
|
Based on some discussion, ACK pending an issue being opened to make this page paginate and select all properly |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The select all functionality of the errata filter by erratum ID was
completely broken after the rails 4 conversion. This commit fixes
a couple of issues when adding erratum to a filter using the select
all functionality.
Also, fixes a couple of minor UI issues on the errata filter pages.
http://projects.theforeman.org/issues/14917