Fixes #15755 - handle race condition on pool import #6196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pool = ::Katello::Pool.where(:cp_id => pool_json['id']).first_or_create | ||
| pool.import_data | ||
| end | ||
| pools.each { |pool_json| ::Katello::Pool.import_pool(pool_json['id']) } |
There was a problem hiding this comment.
Is it no longer necessary to 'import_data' at this point?
There was a problem hiding this comment.
it is, notice i'm calling Pool.import_pool which handles the creation and import_data. The code was duplicated here so i was DRYing it out a bit.
|
The code changes look good. I was not able to reproduce the race condition that this is intended to solve; however, I was able to confirm that I can still create products and repositories as expected. ACK; however, feel free to wait on merging if those that were encountering the race condition are in the process of testing as well. |
|
[test] |
jlsherrill
added a commit
to jlsherrill/katello
that referenced
this pull request
Aug 23, 2016
(cherry picked from commit 0438357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.