Fixes #15818 - Show which capsule a host is registered through #6211
Conversation
|
Testing should be done on both a dev env and a production instance as HTTP headers vary in production mode. |
johnpmitsch
force-pushed
the
capsule_registered_by_15818
branch
from
50bf9bc
to
5ef8477
Compare
|
All seems to be working correctly in production from my testing |
| @@ -198,6 +198,9 @@ def consumer_create | |||
| sync_task(::Actions::Katello::Host::Register, host, System.new, rhsm_params, content_view_environment) | |||
| host.reload | |||
|
|
|||
| parent_host = get_parent_host(request.headers) | |||
| host.subscription_facet.update_attribute(:registered_through, parent_host) | |||
|
|
|||
There was a problem hiding this comment.
this likely needs to be done via consumer_activate too, and I'd suggest doing it on facts (and possibly upload_package_profile too), so that if the client changes what capsule its using it'll automatically update
johnpmitsch
force-pushed
the
capsule_registered_by_15818
branch
from
5ef8477
to
adfb436
Compare
|
@jlsherrill updated with your suggestions |
|
[test] |
1 similar comment
|
[test] |
|
| hostnames = headers["HTTP_X_FORWARDED_SERVER"] | ||
| host = hostnames.split(",")[0] if hostnames | ||
| host || Facter.value(:fqdn) || SETTINGS[:fqdn] | ||
| end |
There was a problem hiding this comment.
Mind writing a test for this function? I think you can likely call it directly on the @controller variable from a controller test file
|
Mind making this searchable? |
|
@jlsherrill is this not working? |
|
@johnpmitsch still in the process of testing it. Seems good so far. Why do you ask? |
| @@ -25,6 +25,7 @@ module SubscriptionFacetHostExtensions | |||
| scoped_search :on => :autoheal, :in => :subscription_facet, :complete_value => true | |||
| scoped_search :on => :service_level, :in => :subscription_facet, :complete_value => true | |||
| scoped_search :on => :last_checkin, :in => :subscription_facet, :complete_value => true | |||
| scoped_search :on => :registered_through, :in => :subscription_facet, :complete_value => true | |||
|
ACK pending testing that function |
This displays the system that a host is registered through in a 'registered_through' field that is searchable and displayed in the content host details page. If the host is registered to the main katello server, the field will display that.
johnpmitsch
force-pushed
the
capsule_registered_by_15818
branch
from
adfb436
to
8597c85
Compare
|
@jlsherrill updated with a test for |
|
@jlsherrill and moved |
|
ACK 👍 |
This displays the system that a host is registered through in a
'registered_through' field that is searchable and displayed in the
content host details page. If the host is registered to the main
katello server, the field will display that.