New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16258 - Skip importer ssl verify for puppet module #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can ya add a quick test for this ? -> APJ pending test |
Tested and this works great! |
johnpmitsch
force-pushed
the
cvpe_capsule_16258
branch
from
August 23, 2016 19:28
50d0716
to
16f731a
Compare
hah, i actually fixed this here: #6234 but you added the test before i did :) APJ |
ContentViewPuppetModules were being checked for verify_ssl_on_sync? but this is not a field for CVPMs
johnpmitsch
force-pushed
the
cvpe_capsule_16258
branch
from
August 24, 2016 14:44
16f731a
to
984d238
Compare
[test] |
[test] |
2 similar comments
[test] |
[test] |
kgaikwad
pushed a commit
to kgaikwad/katello
that referenced
this pull request
Aug 30, 2016
ContentViewPuppetModules were being checked for verify_ssl_on_sync? but this is not a field for CVPMs
jlsherrill
pushed a commit
to jlsherrill/katello
that referenced
this pull request
Aug 30, 2016
ContentViewPuppetModules were being checked for verify_ssl_on_sync? but this is not a field for CVPMs
jlsherrill
pushed a commit
to jlsherrill/katello
that referenced
this pull request
Sep 27, 2016
ContentViewPuppetModules were being checked for verify_ssl_on_sync? but this is not a field for CVPMs Conflicts: app/models/katello/glue/pulp/repo.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentViewPuppetModules were being checked for verify_ssl_on_sync?
but this is not a field for CVPMs