Fixes #17388: fix display of new repository page. #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
getting an error when clicking "save" on the new repo page: |
|
bastion.js:13551 TypeError: Cannot read property 'rows' of undefined |
|
@jlsherrill fixed. |
The new repository page wasn't using the correct ui-view and thus wouldn't show up when visited. This commit changes the ui-router configuration to make the page display as well as renaming the new repository page for consistency and fixing a display issue on that page where the breadcrumbs were being shown twice. http://projects.theforeman.org/issues/17388
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new repository page wasn't using the correct ui-view and thus
wouldn't show up when visited. This commit changes the ui-router
configuration to make the page display as well as renaming the new
repository page for consistency and fixing a display issue on that page
where the breadcrumbs were being shown twice.
http://projects.theforeman.org/issues/17388