Fixes #18122 - move rhsm fact update to run phase #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlsherrill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thomasmckay, @bbuckingham and @bkearney to be potential reviewers. |
beav
reviewed
Jan 18, 2017
| host = ::Host.find(input[:host_id]) | ||
| unless input[:facts].blank? | ||
| ::Katello::Host::SubscriptionFacet.update_facts(host, input[:facts]) | ||
| input[:facts] = 'TRIMMED' |
There was a problem hiding this comment.
Is this part intentional? I didn't see it in the code that got moved into run
There was a problem hiding this comment.
It is, the purpose is so that we do not cause the foreman tasks tasks table to balloon. We do that in other places such as:
During fact importing, RhsmFactName objects are created in large quantity. Because first_or_create is very susceptible to race conditions, we rescue on RecordNotUnique within RhsmFactImporter#add_fact_name. However if duplicate record exception is thrown while in a transaction the entire transaction is aborted. The run phase does not use a transaction so the problem should not occur there.
|
I was not able to reproduce the issue that was initially reported; however, these changes didn't appear to have any negative impacts during my tests. ACK. |
bbuckingham
approved these changes
Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During fact importing, RhsmFactName objects are created
in large quantity. Because first_or_create is very susceptible
to race conditions, we rescue on RecordNotUnique within
RhsmFactImporter#add_fact_name. However if duplicate record
exception is thrown while in a transaction the entire
transaction is aborted. The run phase does not use a transaction
so the problem should not occur there.