Fixes #20207 - Content Views page shows versions out of order. #6849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anandkumaragrawal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bbuckingham, @waldenraines and @parthaa to be potential reviewers. |
|
Issues: #20207 |
jlsherrill
reviewed
Jul 5, 2017
| @@ -15,7 +15,7 @@ end | |||
|
|
|||
| node :last_published do |content_view| | |||
| unless content_view.versions.empty? | |||
| content_view.versions.last.created_at | |||
| content_view.versions.order(:major).last.created_at | |||
There was a problem hiding this comment.
This will ignore minor versions (which are generated by an incremental update). You could do:
content_view.versions.order(:major).order(:minor).last.created_at
or just:
content_view.versions.order(:created_at).last.created_at
There was a problem hiding this comment.
@jlsherrill Thanks for the information. Updated the code as per your suggestion.
|
[test] |
|
ACK thanks @anandkumaragrawal !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.