Fixes #20558 - anon/redhat providers seed idempotency #6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #20558 |
|
[test] |
|
Looks unrelated to me - infra issue. Finished in 70.960493s, 2.7762 runs/s, 4.6505 assertions/s. |
|
[test] |
|
All green, thanks! |
ehelms
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer is hitting "ActiveRecord::RecordInvalid: Validation failed: Providers is invalid" during "db/seeds.d/102-organizations.rb". Futher investigation reveals that create_anonymous_provider is called when there is already anonymous provider present. They had anonymous but not redhat, perhaps they run into issues during migration or script during their upgrade.
We don't know how this happened, but this is not important. What's important that the 102-organizations.rb seed script is supposed to be idempotent, there is a big banner at the top, but these lines are definitely not idempotent. My patch will fix that.