fixes #21274 - determine cvv errata based on errata_counts total #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #21274 |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
waldenraines
approved these changes
Oct 20, 2017
|
[test] |
This is a small change to address an edge case where when a user would view the details of a content view version in the UI, they may not see the Errata tab. This was occuring in cases where the errata_counts had null as the first entry in the result set (e.g. errata_counts['security']==null). Since the version['errata_counts'] (if included) will include a 'total', this logic will use that total to decide if the Errata tab will be shown.
|
Thanks @waldenraines ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to address an edge case where when a user
would view the details of a content view version in the UI, they
may not see the Errata tab.
This was occuring in cases where the errata_counts had null
as the first entry in the result set (e.g. errata_counts['security']==null).
Since the version['errata_counts'] (if included) will include a
'total', this logic will use that total to decide if the
Errata tab will be shown.
To test this specific edge case:
Note: performing a similar scenario with a docker repository only, should illustrate that the Errata tab is not included when not needed.