Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21808 - Correct DockerTag unit import #7100

Merged
merged 1 commit into from Dec 11, 2017

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Dec 2, 2017

Before This commit

::Katello::DockerTag.import_for_repository(repo)
would not update an existing repo. It would not clear the prior
tags before importing new ones from pulp.
This call in particular is used by the promotion operations to update
tags in a CVE repository.

After This commit

This operation is now fixed because the import for repository forcibly
clears out existing tags in the repo before the import actually starts.

@theforeman-bot
Copy link

Issues: #21808

Before This commit

::Katello::DockerTag.import_for_repository(repo)
would not update an existing repo. It would not clear the prior
tags before importing new ones from pulp.
This call in particular is used by the promotion operations to update
tags in a CVE repository.

After This commit

This operation is now fixed because the import for repository forcibly
clears out existing tags in the repo before the import actually starts.
@akofink
Copy link
Member

akofink commented Dec 11, 2017

Probably because I waited so long on testing this PR, but I'm getting this error on Actions::Katello::ContentView::Publish:

NoMethodError: undefined method `ignore_global_proxy' for #<Katello::Repository:0x0000000f805e58>
/home/vagrant/.rvm/gems/ruby-2.2.4/gems/activemodel-4.2.9/lib/active_model/attribute_methods.rb:433:in `method_missing'
/home/vagrant/katello/app/models/katello/glue/pulp/repo.rb:218:in `proxy_host_value'
/home/vagrant/katello/app/models/katello/glue/pulp/repo.rb:249:in `importer_connection_options'
/home/vagrant/katello/app/lib/actions/katello/repository/create.rb:15:in `block in plan'
/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.33/lib/dynflow/execution_plan.rb:346:in `call'
/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.33/lib/dynflow/execution_plan.rb:346:in `switch_flow'
/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.33/lib/dynflow/action.rb:381:in `sequence'
/home/vagrant/katello/app/lib/actions/katello/repository/create.rb:14:in `plan'
/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.33/lib/dynflow/action.rb:473:in `block (3 levels) in execute_plan'
/home/vagrant/.rvm/gems/ruby-2.2.4/gems/dynflow-0.8.33/lib/dynflow/middleware/stack.rb:26:in `call'
...

@parthaa
Copy link
Contributor Author

parthaa commented Dec 11, 2017

Probably because I waited so long on testing this PR, but I'm getting this error on Actions::Katello::ContentView::Publish:

@akofink Not related to this PR. You might need to do a db:migrate

Copy link
Member

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. ACK! Thanks @parthaa!

@parthaa parthaa merged commit a3ca931 into Katello:master Dec 11, 2017
@parthaa parthaa deleted the promote-fix branch December 11, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants