Fixes #23084 - activation-key copy fix

[ranjan]

Activation-key copy fails with "no implicit conversion of nil into String"

[theforeman-bot]

Issues: #23084

[sean797]

Should we add a test for this? But I can confirm this works, backported to my production install.

[jlsherrill]

While this works, i think its missing the root cause.

The problem i think is that here: https://github.com/Katello/katello/blob/master/app/lib/katello/resources/candlepin/activation_key.rb#L91

attrs_to_update and attrs_to_delete were both blank, so result is nil. This causes the json parsing to fail.

[ranjan]

@jlsherrill you are right, but still we should skip the the unwanted method 'set_content_overrides' call if the content_overrides is blank.

[jlsherrill]

@ranjan yeah thats fair, i'd like to see the other code handle that condition better though as well.

also, i'd prefer:
@new_activation_key.set_content_overrides(@activation_key.content_overrides) unless @activation_key.content_overrides.blank?

[jlsherrill]

@ranjan still waiting on the update to https://github.com/Katello/katello/blob/master/app/lib/katello/resources/candlepin/activation_key.rb#L91

[jlsherrill]

Thanks @ranjan !