Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23552 - add keys to table and fix select row formatters #7367

Merged
merged 1 commit into from May 14, 2018
Merged

Fixes #23552 - add keys to table and fix select row formatters #7367

merged 1 commit into from May 14, 2018

Conversation

tstrachota
Copy link
Member

  • Replaces patternfly-react custom formatters with our selection formatters in the upstream subscription table
  • Renames selectionFormatter to more obvious selectionHeaderCellFormatter
  • Removes {props: {index}} from column definitions (they're no longer needed)
  • Fixes Warning: Each child in an array or iterator should have a unique "key" prop.

@theforeman-bot
Copy link

Issues: #23552

Copy link
Contributor

@waldenraines waldenraines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, nice changes. Did some regression testing and couldn't find any issues with these changes.

Thanks @tstrachota!

@waldenraines waldenraines merged commit 9f8bd2b into Katello:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants