Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #23712 - port robottelo test cv filter #7399

Merged
merged 1 commit into from Jun 1, 2018
Merged

fixes #23712 - port robottelo test cv filter #7399

merged 1 commit into from Jun 1, 2018

Conversation

pondrejk
Copy link
Contributor

Port robottelo tier1 api tests for cv filters
part of robottelo minitest port project: https://github.com/SatelliteQE/robottelo/projects/1

Related Robottelo issue: SatelliteQE/robottelo#6008

rake test:katello TEST=../katello/test/models/content_view_filter_test.rb 
# Running:

......S......

Finished in 4.903350s, 2.6512 runs/s, 4.2828 assertions/s.
13 runs, 21 assertions, 0 failures, 0 errors, 1 skips

@theforeman-bot
Copy link

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot
Copy link

Issues: #23712

akofink
akofink approved these changes Jun 1, 2018
View reviewed changes
Copy link
Member

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ACK! Thanks @pondrejk!

@beav beav merged commit afea362 into Katello:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akofink akofink akofink approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
4 participants
@pondrejk @theforeman-bot @akofink @beav