Fixes #24129: fix subs. display when no manifest. #7516
Conversation
|
Issues: #24129 |
| @@ -186,6 +189,16 @@ class SubscriptionsPage extends Component { | |||
|
|
|||
| const csvParams = createSubscriptionParams({ search: this.state.searchQuery }); | |||
|
|
|||
| const emptyStateData = { | |||
There was a problem hiding this comment.
Had to pull this back into the subscriptions page component in order to open the manifest. Open to other solutions.
There was a problem hiding this comment.
@tstrachota especially interested in your opinion on this since you did the initial refactor into the subscriptions table component.
There was a problem hiding this comment.
I see two solutions here:
- The
EmptyStatecomponent currently takes prop action:{url, title}. We can change it to{url, title, onClick}and let the component decide whether to wrap the button withLinkContainer(whenurlis present) or just render a button withonClick. - Alternatively you could keep
EmptyStateas is in this PR and change the empty state date to a function and inject the handler:
const emptyStateData = ({onButtonClick}) => ({
header: __('There are no Subscriptions to display'),
description: __('Import a Manifest to manage your Entitlements.'),
actionButton: (
<Button onClick={onButtonClick}>
{__('Import a Manifest')}
</Button>
),
}};Both solutions seem fine to me. I slightly tend to prefer the first one. Adding actionButton prop feels like adding another way to achieve the same to me.
There was a problem hiding this comment.
@tstrachota updated.
waldenraines
changed the title
There was a problem hiding this comment.
It works well @waldenraines!
I think that we should refactor the empty state as discussed in the other comment. Apart from that it's good.
|
[test katello/webpack] |
When there is no manifest: - Disable "Add subscription" button in the top right toolbar with an appropriate tooltip message. - Show different empty view on the subscriptions page saying "Import a Manifest to manage your Entitlements" or something similar and show "Manage Manifest" button. - Change the text in the add subscriptions empty view to the above. https://projects.theforeman.org/issues/24129
When there is no manifest:
Disable "Add subscription" button in the top right toolbar
with an appropriate tooltip message.
Show different empty view on the subscriptions page saying
"Import a Manifest to manage your Entitlements" or something
similar and show "Manage Manifest" button.
Change the text in the add subscriptions empty view to the above.
https://projects.theforeman.org/issues/24129
TODO